Skip to content

e2e-test: remove iwindowdriver dep #5880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Jan 6, 2025

Summary

  • removed IWindowDriver dependency
  • cleaned up PlaywrightDriver
    • removed some unnecessary wrapper functions
    • replaced deprecated frameLocator() with frameContent()

QA Notes

Ran full suite and everything checks out.

Copy link

github-actions bot commented Jan 6, 2025

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

@midleman midleman marked this pull request as ready for review January 6, 2025 14:09
Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@midleman midleman merged commit 925e428 into main Jan 6, 2025
13 of 14 checks passed
@midleman midleman deleted the mi/remove-inwindow-driver-interface branch January 6, 2025 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants