fix(runtime): Fix inconsistent runtime discovery and selection when deploying from Positron #2708

marcosnav · 2025-07-16T21:50:22Z

Intent

Fix inconsistent runtime discovery and selection when deploying from Positron.

Type of Change

- Bug Fix
- New Feature
- Breaking Change
- Documentation
- Refactor
- Tooling

Approach

The API deployment handler was taking into account the preferred runtime at the beginning but it was ignoring it after some initial validations.

Updated the necessary methods to make use of the preferred runtime across the complete deployment request.

User Impact

Users should be able to deploy with the selected runtime in Positron.

Automated Tests

Updated the related unit tests

Directions for Reviewers

Try deploying content from Positron, while selecting a different R or Python version and seeing the deployment go through with success.

Checklist

I have updated CHANGELOG.md to cover notable changes.

…eploying.

dotNomad

Pulled this down and tried this out in Positron using the VSIX from the CI dist artifact.

I saw the same issue described. When publishing with a non-default R version installed I see the output:

ime=2025-07-17T11:04:10.487-07:00 level=INFO msg="Getting R version" r=/usr/local/bin/R
time=2025-07-17T11:04:10.487-07:00 level=DEBUG msg="Running command" cmd=/usr/local/bin/R args=--version
time=2025-07-17T11:04:10.522-07:00 level=INFO msg="Parsing line for R version" l="R version 4.4.2 (2024-10-31) -- \"Pile of Leaves\""
time=2025-07-17T11:04:10.522-07:00 level=INFO msg="Detected R version" version=4.4.2
ime=2025-07-17T11:04:10.522-07:00 level=DEBUG msg="Successful validation for R executable" rExecutable=/usr/local/bin/R
time=2025-07-17T11:04:10.522-07:00 level=INFO msg="Getting renv lockfile path from R executable" r=/usr/local/bin/R
time=2025-07-17T11:04:10.522-07:00 level=DEBUG msg="Running script" cmd=/usr/local/bin/R args=-s script=renv::paths$lockfile()
time=2025-07-17T11:04:10.529-07:00 level=DEBUG msg="Running command" cmd=/usr/local/bin/R args="-s -f /var/folders/wn/83k9zr2s791brfmfk90c_6vh0000gp/T/3474042576"
time=2025-07-17T11:04:11.179-07:00 level=INFO msg="Parsing line for renv::path output" output="- None of the packages recorded in the lockfile are currently installed."
time=2025-07-17T11:04:11.179-07:00 level=INFO msg="Parsing line for renv::path output" output="- Use `renv::restore()` to restore the project library."

and the error notification

I was able to publish just fine using the default R interpreter on PATH, but when using the non-default I had the problems above. Let me describe a bit of how I got there.

I use rig to install multiple versions of R.

❯ rig list
* name       version    aliases
------------------------------------------
  4.3-arm64  (R 4.3.3)
* 4.4-arm64  (R 4.4.2)  release

When using Positron with that R 4.4.2 install everything works great since that is the R that I'm pointed to on PATH.

When I choose the 4.3.3 interpreter in Positron is when I start to see those errors. 4.3.3 is detected in a ton of spots in the Posit Publisher Deployment output, but as soon as I get to the renv checking it wants to use the R on PATH.

Happy to provide more information on how to reproduce this.

dotNomad · 2025-07-17T17:43:51Z

extensions/vscode/CHANGELOG.md

I think we can leave of VS Code changelog item changes since that usually part of the release flow (to copy over the extension specific changelog items)

This is still lingering, but its totally fine to leave in since the release flow will update it anyway

…o it

marcosnav · 2025-07-18T18:10:37Z

@dotNomad Thank you for trying it out. I pushed a new commit addressing the behavior you are seeing. In more detail, the runtime mismatch was happening in two steps:

Deploying an existing deployment, there is a two step runtime check that was inconsistent, this one got fixed when creating the PR.
Creating a brand new deployment, inspection returns possible configurations, such inspection was using inconsistent runtime versions, the issue you found and now fixed with the latest commit.

marcosnav · 2025-07-18T18:29:53Z

internal/services/api/post_inspect.go

-type postInspectRequestBody struct {
-	Python string `json:"python"`
-	R      string `json:"r"`
-}


This wasn't used anymore, removed it

marcosnav · 2025-07-18T18:32:49Z

internal/services/api/post_inspect.go

+type postInspectHandler struct {
+	base                util.AbsolutePath
+	log                 logging.Logger
+	initializer         configGetter
+	matchingWalker      func([]string, util.AbsolutePath, logging.Logger) (util.Walker, error)
+	interpretersResolve func(util.AbsolutePath, http.ResponseWriter, *http.Request, logging.Logger) (interpreters.RInterpreter, interpreters.PythonInterpreter, error)
+}


Sorry for the bump on changes, I had to re-wire a bit the inspect endpoint handler in order to be testable. We didn't had tests on this one so I went for it.

No worries thanks for adding the additional tests!

marcosnav · 2025-07-18T18:34:31Z

internal/services/api/post_inspect.go

-					return err
-				}
+	// Parse and resolve executable paths for Python and R
+	rInterpreter, pythonInterpreter, err := h.interpretersResolve(projectDir, w, req, h.log)


This is the most important part when it comes to solving the bug. Account for the preferred interpreters coming in the request and use those throughout inspection operations.

Thank you for highlighting this - it makes it much easier to review

dotNomad

Pulled this down and tried this on Positron. I attempted a deploy using the default and non-default R interpreter I have installed using rig - worked great. I also changed the interpreter I had selected, updated the renv.lock and was able to push an update, again worked perfectly.

Absolutely fantastic work @marcosnav

dotNomad · 2025-07-18T18:38:11Z

internal/services/api/post_inspect.go

+type postInspectHandler struct {
+	base                util.AbsolutePath
+	log                 logging.Logger
+	initializer         configGetter
+	matchingWalker      func([]string, util.AbsolutePath, logging.Logger) (util.Walker, error)
+	interpretersResolve func(util.AbsolutePath, http.ResponseWriter, *http.Request, logging.Logger) (interpreters.RInterpreter, interpreters.PythonInterpreter, error)
+}


No worries thanks for adding the additional tests!

dotNomad · 2025-07-18T18:38:46Z

internal/services/api/post_inspect.go

-					return err
-				}
+	// Parse and resolve executable paths for Python and R
+	rInterpreter, pythonInterpreter, err := h.interpretersResolve(projectDir, w, req, h.log)


Thank you for highlighting this - it makes it much easier to review

marcosnav added 2 commits July 16, 2025 13:49

fix(runtime): Fix inconsistent runtime discovery and selection when d…

af1b8b7

…eploying.

Merge main, fix CHANGELOG confilcts

40f8867

marcosnav changed the title ~~fix(runtime): Fix inconsistent runtime discovery and selection when d…~~ fix(runtime): Fix inconsistent runtime discovery and selection when deploying Jul 17, 2025

marcosnav changed the title ~~fix(runtime): Fix inconsistent runtime discovery and selection when deploying~~ fix(runtime): Fix inconsistent runtime discovery and selection when deploying from Positron Jul 17, 2025

marcosnav marked this pull request as ready for review July 17, 2025 15:59

marcosnav requested review from dotNomad and sagerb as code owners July 17, 2025 16:00

marcosnav requested a review from tdstein July 17, 2025 16:00

dotNomad reviewed Jul 17, 2025

View reviewed changes

fix(inspect): Fix inspection, use the preferred interpreters passed t…

e3897a6

…o it

marcosnav requested a review from dotNomad July 18, 2025 18:10

Fix windows scoped unit test

8fc7938

marcosnav commented Jul 18, 2025

View reviewed changes

dotNomad approved these changes Jul 18, 2025

View reviewed changes

marcosnav merged commit f3df906 into main Jul 18, 2025
12 checks passed

marcosnav deleted the mnv-fix-deployment-runtime-mismatch branch July 18, 2025 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(runtime): Fix inconsistent runtime discovery and selection when deploying from Positron #2708

fix(runtime): Fix inconsistent runtime discovery and selection when deploying from Positron #2708

marcosnav commented Jul 16, 2025 •

edited

Loading

Uh oh!

dotNomad left a comment

Uh oh!

dotNomad Jul 17, 2025

Uh oh!

dotNomad Jul 18, 2025

Uh oh!

marcosnav commented Jul 18, 2025

Uh oh!

marcosnav Jul 18, 2025

Uh oh!

marcosnav Jul 18, 2025

Uh oh!

dotNomad Jul 18, 2025

Uh oh!

marcosnav Jul 18, 2025

Uh oh!

dotNomad Jul 18, 2025

Uh oh!

dotNomad left a comment

Uh oh!

dotNomad Jul 18, 2025

Uh oh!

dotNomad Jul 18, 2025

Uh oh!

Uh oh!

Uh oh!

fix(runtime): Fix inconsistent runtime discovery and selection when deploying from Positron #2708

fix(runtime): Fix inconsistent runtime discovery and selection when deploying from Positron #2708

Conversation

marcosnav commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Intent

Type of Change

Approach

User Impact

Automated Tests

Directions for Reviewers

Checklist

Uh oh!

dotNomad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcosnav commented Jul 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dotNomad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marcosnav commented Jul 16, 2025 •

edited

Loading