Skip to content

Disable busy indication in static previews #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

cpsievert
Copy link
Contributor

@cpsievert cpsievert commented Jun 6, 2024

This PR gets rid of the spinners in the input section of https://shiny.posit.co/py/components/ that never go away

input-spinners.mp4

@cpsievert
Copy link
Contributor Author

Merging before a review since this fixes the problem, but @jcheng5 feel free to lmk if this makes sense to you.

@cpsievert cpsievert requested a review from jcheng5 June 6, 2024 14:03
@cpsievert cpsievert merged commit 4b1b434 into main Jun 6, 2024
1 check passed
@cpsievert cpsievert deleted the disable-spinners branch June 6, 2024 14:04
@jcheng5
Copy link
Contributor

jcheng5 commented Jun 6, 2024

LGTM, thanks for jumping on that.

schloerke added a commit that referenced this pull request Jul 17, 2024
* main:
  feat: Enable repo-actions (#175)
  Fix link to shinylive examples (#174)
  Abstract out express_core_preview() internals into a app_preview_code() helper so that shiny-dev-center can use it (#172)
  #155 update id (#170)
  Update Quarto to 1.4.557 (#169)
  Add deployment overview doc (#166)
  fix database-explorer preview image
  reubuild docs with latest py-htmltools (#164)
  Follow up to #159: auto-detect language in append_shinylive_chunk() (#161)
  Update shinylive helpers to better support R (#159)
  Enable fast mode (#157)
  Disable busy indication in static previews (#156)
  QA fixes for components/templates (#150)
  Update shiny and shinylive (#154)
  Update shiny-vscode link (#153)
  reactive-mutable: tweak problem/solution examples (#151)
  Update py-shiny and py-shinylive (#149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants