Eliminate the possibility of a single render_widget output from keeping a view of prior renders#196
Merged
Eliminate the possibility of a single render_widget output from keeping a view of prior renders#196
render_widget output from keeping a view of prior renders#196Conversation
…ce multiple widget views on a given element
Shiny.OutputBinding.renderValue() producing multiple widget viewsrender_widget output from keeping a view of prior renders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up (in a sense) to #191 and #195. Now that we only close widgets (server-side) when they're created in an output context, it is technically possible to render the same widget repeatedly in a render function, which leads to duplicated views of that widget. For example, clicking the button here will generate duplicate views:
This PR fixes that issue by resurrecting some cleanup code we had before doing server-side cleanup