Skip to content

Add markdown_stream() #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Add markdown_stream() #23

merged 6 commits into from
Feb 12, 2025

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jan 30, 2025

In anticipation of posit-dev/py-shiny#1782, which adds ui.MarkdownStream() to Shiny for Python

  • 83c0f3d does a minimal change of just pulling in the new markdown-stream JS/CSS assets that the chat component will now depend upon.
  • 9f36cb0 takes a first pass at adding markdown_stream() and output_markdown_stream().

Open questions

  • Is shinychat a proper home for markdown_stream()?
  • How best to handle mid-stream errors? Show them in a notification? Should they crash the app?

TODO

@cpsievert cpsievert marked this pull request as draft January 30, 2025 16:16
@cpsievert cpsievert changed the title Accomodate incoming markdown-stream web component from py-shiny Add markdown_stream() Jan 30, 2025
@cpsievert cpsievert marked this pull request as ready for review February 12, 2025 02:27
@cpsievert cpsievert requested a review from jcheng5 February 12, 2025 02:27
@cpsievert
Copy link
Collaborator Author

@jcheng5 I'm gonna merge before a review since I'd like to demo it tomorrow, but please feel free to review and I'll address in a follow up PR

@cpsievert cpsievert merged commit 8d41729 into main Feb 12, 2025
6 checks passed
@cpsievert cpsievert deleted the chat-markdown-stream branch February 12, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant