Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement colonychain #38

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Implement colonychain #38

wants to merge 7 commits into from

Conversation

chemonoworld
Copy link
Member

@chemonoworld chemonoworld commented Sep 6, 2022

Just for review

Select at least one type

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • Bug fix
  • Dependency, Environment, Build related update
  • Documentation
  • Other tiny fix

Describe your changes

  • change "astar" to "shiden"
  • implement check_connection and get_last_block in ColonyChain
  • add treasury_address and light_client_address to Struct

Issue ticket number and other helpful resource

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • Leave reference about this pull request, if exist (ex. discord message,
    google docs, etc)
  • If it is a core feature, I have added thorough tests.

Checklist after creating a pull request

  • Mention reviews in discord channel directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants