feat: introduce VictoriaMetrics/metrics histograms #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as those aren't deterministic the resulting metrics were not consistent. variadic functions are also simpler!
Pull Request Test Coverage Report for Build 15682559060Details
💛 - Coveralls |
sebastian-stephan
requested changes
Jun 16, 2025
Co-authored-by: Sebastian Stephan <[email protected]>
clementnuss
added a commit
that referenced
this pull request
Jun 16, 2025
as a followup to #214 (comment)
as a followup to #214 (comment)
clementnuss
force-pushed
the
feat/vm-metrics-library
branch
from
10fe6a6 to
2801ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes it possible to choose between
PrometheusHistogram(introduced here) or VictoriaMetrics histograms.the former keep the actual behaviour, with predefined histogram buckets, while the latter introduce VictoriaMetrics
vmrangebuckets, as introduced by @valyala here.here's a comparison between the 2 flavours. I let you decide which one is more informative 😉