Added ability to set volume per (connected) device #2673
Conversation
…ume updates of output devices. Volume is stored in the OutputDevice structure that has been enriched. This event completes the set_device_volume method that lets set volume to a given output device id
|
EDIT : I also added a new event to be notified when the volume of output devices changes |
|
Thank you, I will review this later tonight. But you have to revert the changes related to protobuf. |
|
Hi, it's done and tests passed |
postlund
left a comment
postlund
left a comment
There was a problem hiding this comment.
Looks good overall, but a few comments to make conform with how the API generally work in pyatv. I would also like to see some kind of test (unit test in facade for instance) since this is new functionality.
|
Hi again, I have added a test for device volume update and tested ok. There is one thing that I changed partially : you requested OutputDevice class in the interfaces.py to be immutable. To be honest I don't know how to do this in an easy way : the volume property needs to be updated. |
|
Hi @postlund did you have the time to look after the recent changes ? thank you |
|
Hi @postlund any news here ? thank you |
|
@albaintor Can you take a look at this because I believe you have changed line endings or something. All files more or less as marked as changed. I would also like you to remove the "tvOS 18.4" commit as that has been merged already. |
|
Hi, I don't know what happened with CRLF... this is fixed. I also removed the tvOS 18.4 patch. About using immutable data whereas I need to send updated data (updated volume) |
…to device_volume
|
Hi @postlund , did you have the time to look after my PR ? thank you |
2 participants
Actually the volume set is only done on the AppleTV side. But when you set your AppleTV to cast audio to multiple devices (homepod or any Airplay speaker), the set volume won't affect the other devices.
I added a new endpoint to specify the endpoint id while setting volume, in order to be able to reproduce the global volume slider from the notification center (it lets change all volumes at the same time).
This is related to this ticket : #2672