-
-
Notifications
You must be signed in to change notification settings - Fork 110
feat: add auto-hmr-plugin and autoHmr option #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds a new unplugin-based auto-HMR plugin that injects import and invocation of Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-08-16T13:00:51.271ZApplied to files:
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
src/auto-hmr/index.ts (1)
77-77: Regex reliability concern.Same issue as line 35 - regex matching in code can be unreliable.
🧹 Nitpick comments (1)
src/auto-hmr/index.ts (1)
35-35: Consider regex reliability.The regex
/handleHotUpdate\([\s\S]*?\)/may match unintended occurrences like comments or strings. Consider using AST-based detection instead.- const handleHotUpdateCallRegex = /handleHotUpdate\([\s\S]*?\)/Use AST parsing to detect function calls more reliably:
function hasHandleHotUpdateCall(ast: any): boolean { // Walk AST to find CallExpression with callee.name === 'handleHotUpdate' }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/auto-hmr/index.ts(1 hunks)src/index.ts(2 hunks)src/options.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/index.ts (2)
src/auto-hmr/index.ts (1)
createAutoHmrPlugin(34-101)src/core/moduleConstants.ts (1)
MODULE_ROUTES_PATH(6-6)
🔇 Additional comments (11)
src/options.ts (1)
216-220: LGTM!Clean addition of the new option with proper documentation.
src/index.ts (2)
24-24: Clean import addition.
206-212: Good integration pattern.Follows the same conditional plugin inclusion pattern as the experimental autoExportsDataLoaders.
src/auto-hmr/index.ts (8)
4-6: Helper function is correct.
8-15: Router detection logic is sound.
17-28: Import detection logic is correct.
42-42: Virtual module filtering is correct.
46-48: Early return optimization is good.
82-86: Import injection looks correct.
89-91: Function call injection is correct.
93-95: Code transformation approach is sound.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
This reverts commit 7abc277.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@posva PTAL |
posva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and sorry for the delay!
| name: 'unplugin-vue-router-auto-hmr', | ||
| enforce: 'post', | ||
|
|
||
| transform(code, id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a filter like the one added for the main plugin (src/index.ts). We should be able to write a regex that checks the code for a router creation like /\w+\s*=\s*(?:experimental_)?createRouter\(/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's also worth filtering only on files like router/index and router and allow configuring it
| if (options.autoHmr) { | ||
| plugins.push( | ||
| createAutoHmrPlugin({ | ||
| modulePath: MODULE_ROUTES_PATH, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be either vue-router/auto-routes or vue-router/auto-resolver depending of whether experimental.paramParsers is activated
| * Whether to enable auto HMR for Vue Router. | ||
| * @default `false` | ||
| */ | ||
| autoHmr?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be an object to match the other use cases. Probably an enabled option will also make sense instead of a boolean and I think we can enable it by default.
reimpl: #617
This pr is similar to the implementation of vuejs/pinia#2954, which transfers the work of automatically injecting hmr code to the plugin part, and adds an option to control whether the plugin is enabled or not.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.