Added Chrome for Testing instead of Chromium #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppodgorsek I have updated the Firefox version to fix the build: |
|
Hello @andy-kru, thank you very much for your contribution! Sorry for the delay in getting back to you, I had to take care of some personal stuff for the last few months. I agree with you, the branded Chrome is the browser end users rely on rather than Chromium, tests would be more accurate with it. I've updated most dependency versions of the project today, I'll take care of your PR tomorrow. |
* Merged the latest master branch into this one * Simplified the Chrome for Testing setup
|
The PR has slightly simplified and merged. Thanks again for your help, @andy-kru ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Chrome for Testing: https://developer.chrome.com/blog/chrome-for-testing
It can potentially fix issues like #482 due to better compatibility between ChromeDriver and Chrome for Testing.