SDL3: Add hack to make resizing store windowed size to config #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows users to precisely adjust window size - Keeps the workaround for ppy#6264 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrackedSettingforWindowedSizeis no longer updated during a resize on windows #6489 (comment)This PR changes the buggy workaround introduced in ff2ee9d to only apply when the user is not holding left click. I.e. if the user is holding left click (when resizing the window), windowed size will be stored to config.
#6264 (comment) should not regress with this change. The user is unlikely to be holding left click when changing the window mode to borderless:
Please test it with of! Tests → Platform → Borderless. If you hold left click, the test should fail (macOS and Linux).