Skip to content

Optimise package-related operations #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Conversation

bdach
Copy link
Contributor

@bdach bdach commented Dec 23, 2024

  • Depends on Add submission-relevant events to database via LIO endpoints #11

  • Use versioning database tables for listing latest package version contents rather than the actual package itself. This is desirable because in production this is going to hit S3 to get the package rather than the filesystem and hitting S3 is very likely going to be slower.

  • When performing package updates, actually check that there are any meaningful changes to the package. If there are none, skip every database update call & remote procedure calls.

@bdach bdach self-assigned this Dec 23, 2024
This was referenced Dec 23, 2024
@peppy peppy self-requested a review December 24, 2024 06:14
@peppy peppy merged commit d5d444c into ppy:master Dec 24, 2024
4 checks passed
@bdach bdach deleted the optimise-package-ops branch December 24, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants