Skip to content

Ensure the beatmap set host's current username is consistent with the creator field of submitted beatmaps #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

bdach
Copy link
Contributor

@bdach bdach commented Feb 10, 2025

This is the case in stable BSS. I initally avoided porting these checks as I must have seen them as pointless but after discussions elsewhere I realise that was probably an incorrect assessment.

Note that this may be seen as a bit strange / not necessarily make very much sense in isolation for guest beatmaps, but I'm choosing to ignore that for the time being, because guest support isn't getting added client-side immediately anyway. Not until guest difficulties are displayed properly all over (in song select and such).

This contains many test changes because it turns out that the one set we've been using for testing all over is the very rare exception to the rule - it was compiled from other people's works internally as part of a contest, so it is expected and normal that it has differing Creator: values across the set. But for the tests to pass, something has to give, so the archive has been changed here to specify a single creator across all difficulties. There were also several knock-on related test fixes that I will not elaborate on here because I'm not sure it's worth the time to do so.

@bdach bdach requested a review from peppy February 10, 2025 13:42
@bdach bdach self-assigned this Feb 10, 2025
@peppy peppy merged commit 1c9c7bc into ppy:master Feb 13, 2025
4 checks passed
@bdach bdach deleted the check-username branch February 13, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants