Fix incorrect validation of circle size / key count #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The big issue is that the range specified on the attribute was [1, 18] which only makes sense in mania. The small issue that while the range was checked, nothing decimal should really be allowed for mania anyway. A significant amount of this is kind of much-of-muchness because `LegacyBeatmapDecoder` already does clamping on this: https://github.com/ppy/osu/blob/834d63d1deacf0be0c4e76cd5d47cee136fbb49a/osu.Game/Beatmaps/Formats/LegacyBeatmapDecoder.cs#L113-L131 so the checks are kind of dead in practice, but I'd rather have them not, what with users' propensity to try and break stuff and not have us notice that it happened. The game package bump here is significant because it exposes `LegacyBeatmapDecoder.MAX_MANIA_KEY_COUNT`.
smoogipoo
approved these changes
Apr 21, 2025
peppy
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big issue is that the range specified on the attribute was [1, 18] which only makes sense in mania.
The small issue that while the range was checked, nothing decimal should really be allowed for mania anyway.
A significant amount of this is kind of much-of-muchness because
LegacyBeatmapDecoderalready does clamping on this, so the checks are kind of dead in practice, but I'd rather have them not, what with users' propensity to try and break stuff and not have us notice that it happened.The game package bump here is significant because it exposes
LegacyBeatmapDecoder.MAX_MANIA_KEY_COUNT.