Add various sanity checks concerning contents of beatmap package #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
force-pushed
the
sanity-checks-2
branch
from
8695165 to
a9f0448
Compare
bdach
force-pushed
the
sanity-checks-2
branch
from
a9f0448 to
af542b3
Compare
not sure what happened...?
peppy
reviewed
Nov 28, 2024
peppy
reviewed
Nov 28, 2024
A bit crude, but apparently there is no sane normalisation API in the BCL... Closest thing is `Path.GetFullPath()` overload that takes a root, but that's not OS-portable, so I can't use it.
bdach
added a commit
to bdach/osu
that referenced
this pull request
Nov 28, 2024
bdach
added a commit
to bdach/osu
that referenced
this pull request
Nov 29, 2024
bdach
added a commit
to bdach/osu
that referenced
this pull request
Nov 29, 2024
LittleEndu
reviewed
Nov 29, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
peppy
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers:
.osus are valid.osus that should be in the package are in it, and that there are no moreSkipping upload if nothing actually changed is going to likely be delayed until I address another item from #2, namely "Use beatmap versioning tables for listing package contents rather than extracting the package" - that listing capability is going to come useful for that check.