Add country filter for score ranking #12012
Merged
+76
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
approved these changes
Mar 18, 2025
|
pinging @peppy to confirm db change and migration entry |
peppy
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final goal is to allow same filters between performance and score sorting option just like on team ranking page (and reducing number of menu items). The index is similar to the one used for performance so performance characteristics should be the same.
The columns are also added for variant statistics but the process for updating it isn't in place (yet?) so it's still one step short from being able to have sort buttons.
Migration entry is
2025_03_18_065831_add_country_ranked_score_index_to_stats_tables.