Attempt to render game detail with no start event #12247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanaya
force-pushed
the
match-missing-start
branch
2 times, most recently
from
eb630b1 to
cf7eaaa
Compare
notbakaneko
approved these changes
Jun 20, 2025
notbakaneko
requested changes
Jun 20, 2025
| @@ -47,7 +48,7 @@ public function includeBeatmap(PlaylistItem $item) | |||
| public function includeDetails(PlaylistItem $item) | |||
| { | |||
| return $this->primitive($item->detailEvent->event_detail ?? [ | |||
| 'room_type' => $item->room->type, | |||
| 'room_type' => Room::REALTIME_DEFAULT_TYPE, | |||
There was a problem hiding this comment.
wait, what's this change for?
There was a problem hiding this comment.
otherwise it may be shown as team match which wouldn't make sense without the team member data.
notbakaneko
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe? ┐(･_･)┌
Not quite sure how it happened but it'll be either this or retroactively adding the past event which probably isn't even possible due to id-based sorting