Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ZH] Add Gameplay/Judgement #10606

Merged
merged 6 commits into from
Dec 6, 2023
Merged

[ZH] Add Gameplay/Judgement #10606

merged 6 commits into from
Dec 6, 2023

Conversation

proxyerium
Copy link
Contributor

@proxyerium proxyerium commented Dec 4, 2023 •
edited
Loading

Self-check

Changes

  • Add Gameplay/Judgement/zh.md
  • Add Gameplay/Judgement/osu!/zh.md

@proxyerium
Copy link
Contributor Author

翻译相关的疑问 question about my translation:

  • Hit window 指的是圆环收缩至圆圈的动画期间，还是代码判定误差的逻辑期间？因为不确定所以弄出来判定区域、判定范围、判定区间，不懂怎么决定😥。

CloneWith
CloneWith reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@CloneWith CloneWith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

翻译相关的疑问 question about my translation:
- Hit window 指的是圆环收缩至圆圈的动画期间，还是代码判定误差的逻辑期间？因为不确定所以弄出来判定区域、判定范围、判定区间，不懂怎么决定😥。

个人建议用判定区间。本文提及的区间是和 整体难度(OD) 对应的。

圆环收缩的动画过程由 缩圈速度(AR) 控制。

wiki/Gameplay/Judgement/osu!/zh.md Outdated Show resolved Hide resolved
CloneWith
CloneWith reviewed Dec 5, 2023
View reviewed changes
wiki/Gameplay/Judgement/osu!/zh.md Outdated

### 圆圈

根据连击的准确程度，[圆圈](/wiki/Gameplay/Hit_object/Hit_circle) 的判定可分为GREAT，OK，MEH 和 MISS。在MISS判定区间之前的点击不会生效（或者触发 [物件锁](/wiki/Gameplay/Judgement/Notelock) ）；在MEH判定区间结束前未点击会判定为MISS。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
根据连击的准确程度，[圆圈](/wiki/Gameplay/Hit_object/Hit_circle) 的判定可分为GREAT，OK，MEH 和 MISS。在MISS判定区间之前的点击不会生效（或者触发 [物件锁](/wiki/Gameplay/Judgement/Notelock) ）；在MEH判定区间结束前未点击会判定为MISS。
根据连击的准确程度，[圆圈](/wiki/Gameplay/Hit_object/Hit_circle) 的判定可分为GREAT，OK，MEH 和 MISS。在MISS判定区间之外的点击不会生效（此时会触发 [物件锁](/wiki/Gameplay/Judgement/Notelock) ）；在MEH判定区间结束前未点击会判定为MISS。

Copy link
Contributor Author

@proxyerium proxyerium Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个感觉有“此时正在发生物件锁”的歧义，要不改成此时点击会触发

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以，按你说的改🎉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔物件锁点在其他物件上才发生，这里的意思也是说两种情况，那就不应该用“此时”了。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved in new commits

CloneWith
CloneWith suggested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@CloneWith CloneWith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全文相关的都要改成打击区间，因为是同一个意思

@proxyerium proxyerium requested a review from CloneWith December 5, 2023 05:15
@TicClick TicClick enabled auto-merge December 6, 2023 08:37
@TicClick TicClick merged commit 8e05d6e into ppy:master Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CloneWith CloneWith CloneWith approved these changes

@TicClick TicClick TicClick approved these changes

Assignees
No one assigned
Labels
area:translations size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@proxyerium @TicClick @CloneWith @cl8n