Add osu! World Cup 2023 Concludes news post
#10619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pishifat <[email protected]> Co-authored-by: Walavouchey <[email protected]> Co-authored-by: 0x84f <[email protected]>
Walavouchey
force-pushed
the
MChecaH-news-osu!recap
branch
from
363c302 to
8f23b63
Compare
|
the rest i would say is beautifully written and i am glad that i participated in this :) |
Hiviexd
reviewed
Dec 9, 2023
peppy
reviewed
Dec 10, 2023
Co-authored-by: Hivie <[email protected]>
peppy
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web preview
this is a long post. the osu! originals are presented here instead of a separate one as discussed with pishi
of particular note, some localised css is added to make sure the audio players don't look terrible. hopefully this isn't too contentious
embedded iframes and audio players don't have bottom margins by default, so the "osu-md__paragraph" is added to each (looked especially bad for the audio players). this should probably be the case in all news posts, though in fa posts it doesn't look bad because headings have large top margins
SKIP_WIKILINK_CHECK ci bug (tracking at Walavouchey/osu-wiki-tools#23)