Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add History of osu!/2010 #10622

Merged
merged 16 commits into from
Mar 20, 2024
Merged

Add History of osu!/2010 #10622

merged 16 commits into from
Mar 20, 2024

Conversation

The-Last-Cookie
Copy link
Contributor

@The-Last-Cookie The-Last-Cookie commented Dec 10, 2023

This time for real I hope 😄

As I did in #9943, I searched information mostly in the Announcements and Development forums.

Related to #4871

Linking 2010 in the main article will be done in a follow-up PR.

  • Check infobox design?

Self-check


## August

Since August 2, users became able to change their username once. To change their name, they had to have received an osu!supporter tag at least once beforehand, either through purchase or as a gift.[^name-change]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed the osu!supporter system was the same from 2009 compared to now. If I'm wrong here, please correct me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a question for @peppy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume that this is correct, and is when name changes first became available? That's what it's saying anyway.

wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
@The-Last-Cookie
Copy link
Contributor Author

For your information, I'm still waiting for a review here.

The CI error is coming from a file not concerning this PR.

@Walavouchey Walavouchey self-requested a review January 19, 2024 13:52
@TicClick TicClick self-requested a review January 25, 2024 12:52
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 8, 2024
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as expected, the infobox area looks subpar because there isn't much text on the left -- have to roll it back I think:

image

other than that, there are unresolved comments, some of which wait for peppy's feedback

@pull-request-size pull-request-size bot added size/M and removed size/L labels Feb 9, 2024
@TicClick TicClick requested a review from peppy February 13, 2024 00:48
TicClick
TicClick previously approved these changes Feb 13, 2024
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough for me, but there are a few unresolved questions

Copy link
Contributor Author

@The-Last-Cookie The-Last-Cookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my idea to integrate what was left to discussion.

For the record, cheating with Flashlight was possible (among editing the client) by increasing the screen's gamma value. See Willy's video on Flashlight.

wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Show resolved Hide resolved
Co-authored-by: The-Last-Cookie <[email protected]>
TicClick
TicClick previously approved these changes Mar 11, 2024
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
wiki/History_of_osu!/2010/en.md Outdated Show resolved Hide resolved
Co-authored-by: Walavouchey <[email protected]>
@The-Last-Cookie
Copy link
Contributor Author

Ready for final review.

@Walavouchey Walavouchey enabled auto-merge March 20, 2024 22:45
@Walavouchey Walavouchey merged commit 54493eb into ppy:master Mar 20, 2024
2 checks passed
@The-Last-Cookie The-Last-Cookie deleted the history-2010 branch March 29, 2024 13:27
@The-Last-Cookie The-Last-Cookie mentioned this pull request Mar 29, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants