Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] Update People, People/Community Contributors, People/Users with unique titles and People/osu! team #10662

Merged
merged 7 commits into from
Feb 28, 2024

Conversation

The-Last-Cookie
Copy link
Contributor

@The-Last-Cookie The-Last-Cookie commented Dec 17, 2023

Self-check

wiki/People/Community_Contributors/de.md Outdated Show resolved Hide resolved
| ::{ flag=US }:: [radar](https://osu.ppy.sh/users/7131099) | Herausragende Führung zu Angelegenheiten im Beatmap-Management |
| ::{ flag=US }:: [Cychloryn](https://osu.ppy.sh/users/6921736) | Herausragende Beiträge zur Mappingszene durch die Entwicklung von Tools ([osumod.com](https://osumod.com)) |
| ::{ flag=US }:: [BTMC](https://osu.ppy.sh/users/3171691) | Herausragende Beiträge zu Offline-Turnieren und dem Wachstum der Community allgemein |
| ::{ flag=CA }:: [D I O](https://osu.ppy.sh/users/3958619) | Herausragende Beiträge zur osu!-Turnierszene und den World Cups |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some time ago, respektive and I decided to use World Cup instead of Weltmeisterschaft (I assume due to a longer term containing "World Cup" which doesn't sound well when translated). Should this still be a thing? 🤔

In my opinion it's fine. I wanted to ask what others think of this.

Copy link

Your translation may be missing new pending changes to English articles. Please update your translation after they are merged:

@The-Last-Cookie
Copy link
Contributor Author

Please don't merge this yet. This will be reviewed once I have more time (very likely next month).

Copy link

Your translation may be missing new pending changes to English articles. Please update your translation after they are merged:

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 8, 2024
Copy link

Your translation may be missing new pending changes to English articles. Please update your translation after they are merged:

@The-Last-Cookie
Copy link
Contributor Author

@FreezyLemon Hey there! You said that you wanted to help in reviewing my PRs but wait until I'm more available. I think now is the best time for that ^^ Are you still around by any chance? (This also applies to #10696, #10913, and #10915)

@FreezyLemon
Copy link
Contributor

@FreezyLemon Hey there! You said that you wanted to help in reviewing my PRs but wait until I'm more available. I think now is the best time for that ^^ Are you still around by any chance? (This also applies to #10696, #10913, and #10915)

Yeah, I'll take a look over the next few days, maybe on the weekend

wiki/People/Community_Contributors/de.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/de.md Outdated Show resolved Hide resolved
wiki/People/Community_Contributors/de.md Outdated Show resolved Hide resolved
wiki/People/Users_with_unique_titles/de.md Outdated Show resolved Hide resolved
wiki/People/Users_with_unique_titles/de.md Outdated Show resolved Hide resolved
@The-Last-Cookie
Copy link
Contributor Author

member_list

These member lists are so messy in the diff. Every time I need to go through the changes, I feel deeply uncomfortable. The changes are so easy to miss. I hope that we will have a better system in place in the future.

@TicClick TicClick requested a review from FreezyLemon February 27, 2024 23:33
@TicClick TicClick enabled auto-merge February 28, 2024 11:45
@TicClick TicClick merged commit 08a355c into ppy:master Feb 28, 2024
2 checks passed
@The-Last-Cookie The-Last-Cookie deleted the de-people branch February 28, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants