Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT-BR] Add Bit rate #10868

Merged
merged 4 commits into from
Feb 27, 2024
Merged

[PT-BR] Add Bit rate #10868

merged 4 commits into from
Feb 27, 2024

Conversation

flavin27
Copy link
Contributor

@flavin27 flavin27 commented Jan 30, 2024 •
edited by TicClick
Loading

Self-check

@cl8n cl8n changed the title [PT-BR]: Add bit rate [PT-BR] Add bit rate Feb 3, 2024
@TicClick
Copy link
Contributor

TicClick commented Feb 4, 2024

hi, I have cleared the second checkbox since I don't see a review from a Portuguese-speaking person. whether you are looking for one or not, let me know -- I'll either merge it in as-is with no_native_review: true, or wait until a native speaker approves your work

@flavin27
Copy link
Contributor Author

flavin27 commented Feb 5, 2024

well even thought I'm native speaker, I would like to wait for someone else's review.
tbh I though there was someone who speaks Portuguese in ppy to be in charge for reviewing.

@TicClick
Copy link
Contributor

TicClick commented Feb 9, 2024

not really, it's a free will model (whoever wants it, does a review)

@TicClick TicClick added the state/stale merge merged due to inactivity label Feb 27, 2024
@TicClick TicClick changed the title [PT-BR] Add bit rate [PT-BR] Add Bit rate Feb 27, 2024
TicClick
TicClick approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@TicClick TicClick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point there's been enough silence to warrant merge with no_native_review: true, which I'm doing right now

@TicClick TicClick enabled auto-merge February 27, 2024 23:49
@TicClick TicClick merged commit 64987d9 into ppy:master Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TicClick TicClick TicClick approved these changes

Assignees
No one assigned
Labels
area:translations size/S state/stale merge merged due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flavin27 @TicClick @cl8n