Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN/ZH] Add / Update Guides/Audio editing #10919

Merged
merged 13 commits into from
Sep 12, 2024
Merged

Conversation

CloneWith
Copy link
Contributor

@CloneWith CloneWith commented Feb 9, 2024

Self-check

Changes

  • Clarify the version of softwares the article is using
  • Simplify description

Changed files

  • M /wiki/Guides/Audio_editing/en.md
    • A /wiki/Guides/Audio_editing/zh.md

wiki/Guides/Audio_editing/zh.md Outdated Show resolved Hide resolved
wiki/Guides/Audio_editing/zh.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I generally agree that the guide can be simplified, [Export](#lowering-bit-rate) the audio file takes the reader to the section about bit rate lowering, and while it covers the export process, I would say it's confusing -- you need to either make a small section dedicated to the export procedure, or keep duplicated steps as below in the mp3directcut part of the article

@TicClick
Copy link
Contributor

(also, what does your "Sync changes with the English article" checkbox mean -- is there still something you wanted to backport from Chinese to English and forgot?)

@CloneWith
Copy link
Contributor Author

CloneWith commented Feb 28, 2024

what does your "Sync changes with the English article" checkbox mean

The Chinese translation reflects the original content before this PR.
This step will be completed once I have the English article cleaned up.


Uh I seem not to explain it clearly, so I changed it.

@CloneWith
Copy link
Contributor Author

CloneWith commented Feb 28, 2024

you need to either make a small section dedicated to the export procedure, or keep duplicated steps as below in the mp3directcut part of the article

some issues encountered when setting mp3DirectCut up:

  • It complains ACM not found, even after I installed this library
  • For LAME library, I'm unsure about which bitrate to use (Constant, Variable, Average) and which is used by our RC
  • It only runs on Windows (requires x86 libraries) and Android, and hasn't been updated since 2022/01
  • If we have the need to change the bitrate, we need either of the two libraries mentioned above

It seems kinda unfriendly for regular mappers. Maybe there is a better approach to edit MP3 files, but I'll try to update the current ones first.

Interface

@CloneWith CloneWith requested a review from TicClick April 28, 2024 13:39
@cl8n cl8n changed the title [EN+ZH] Add / Update Guides/Audio editing [EN/ZH] Add / Update Guides/Audio editing May 10, 2024
@TicClick
Copy link
Contributor

this has been going on for quite a while, so let's try and finally get it in. please make sure the Chinese translation you added follows the updated version of the guide, and I'll merge it

@CloneWith
Copy link
Contributor Author

Now the ZH translation is up to date. Ready to go 🚀

@TicClick TicClick enabled auto-merge September 12, 2024 19:27
@TicClick TicClick merged commit c2b3682 into ppy:master Sep 12, 2024
2 checks passed
@CloneWith CloneWith deleted the guides/audio branch January 31, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants