-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EN/ZH] Add / Update Guides/Audio editing
#10919
Conversation
Co-authored-by: YumeMuzi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while I generally agree that the guide can be simplified, [Export](#lowering-bit-rate) the audio file
takes the reader to the section about bit rate lowering, and while it covers the export process, I would say it's confusing -- you need to either make a small section dedicated to the export procedure, or keep duplicated steps as below in the mp3directcut part of the article
(also, what does your "Sync changes with the English article" checkbox mean -- is there still something you wanted to backport from Chinese to English and forgot?) |
The Chinese translation reflects the original content before this PR. Uh I seem not to explain it clearly, so I changed it. |
some issues encountered when setting mp3DirectCut up:
It seems kinda unfriendly for regular mappers. Maybe there is a better approach to edit MP3 files, but I'll try to update the current ones first. |
Guides/Audio editing
Guides/Audio editing
this has been going on for quite a while, so let's try and finally get it in. please make sure the Chinese translation you added follows the updated version of the guide, and I'll merge it |
Now the ZH translation is up to date. Ready to go 🚀 |
Self-check
Changes
Changed files