Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ID] Update News styling criteria #10931

Merged
merged 9 commits into from
Feb 27, 2024
Merged

[ID] Update News styling criteria #10931

merged 9 commits into from
Feb 27, 2024

Conversation

aritlhq
Copy link

@aritlhq aritlhq commented Feb 11, 2024 •
edited
Loading

Self-check

@github-actions GitHub Actions
Copy link

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

aritlhq
aritlhq commented Feb 11, 2024
View reviewed changes
Copy link
Author

@aritlhq aritlhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fix spaces in the link.

aritlhq
aritlhq commented Feb 11, 2024
View reviewed changes
Copy link
Author

@aritlhq aritlhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed it again.

aritlhq
aritlhq commented Feb 11, 2024
View reviewed changes
Copy link
Author

@aritlhq aritlhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've reviewed again

aritlhq
aritlhq commented Feb 11, 2024
View reviewed changes
wiki/News_styling_criteria/id.md

- Judul tingkat 1 (`#`), yang berkaitan dengan suatu judul, tidak boleh digunakan, karena judul terdapat pada bagian depan di bagian atas artikel.
- [Kotak info](/wiki/Article_styling_criteria/Formatting#infoboxes) dan [catatan kaki](/wiki/Article_styling_criteria/Formatting#footnotes) tidak didukung.
- Gambar [spanduk](#spanduk) tidak boleh berisi teks alternatif apa pun, yaitu teks di dalam tanda kurung siku pada tautan gambar di markdown (`![alt text](image.png)`).
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fix spaces in the link.

aritlhq
aritlhq commented Feb 11, 2024
View reviewed changes
Copy link
Author

@aritlhq aritlhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks ok

@iSlodinxOsu
Copy link
Contributor

Please change the title to [ID] Update News styling criteria

@aritlhq aritlhq changed the title Added a new translation (i.e. Indonesian) [ID] Update News styling criteria Feb 11, 2024
@aritlhq
Copy link
Author

aritlhq commented Feb 11, 2024

Please change the title to [ID] Update News styling criteria

Okay done

@osu-wiki-observatory osu-wiki-observatory
Copy link

Your translation may be missing new pending changes to English articles. Please update your translation after they are merged:

TicClick
TicClick approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging (no native review for one week or longer) while ignoring the above notice (an update of the original page) since it may put this PR on hold for even longer

@TicClick TicClick enabled auto-merge February 27, 2024 12:42
@TicClick TicClick merged commit f33e4d3 into ppy:master Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TicClick TicClick TicClick approved these changes

Assignees
No one assigned
Labels
area:translations size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aritlhq @iSlodinxOsu @TicClick