Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Game mode/osu!taiko #11000

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Update Game mode/osu!taiko #11000

merged 4 commits into from
Feb 29, 2024

Conversation

SherlockWh0
Copy link
Contributor

@SherlockWh0 SherlockWh0 commented Feb 21, 2024

My first contribution! Please give feedback.

Self-check

Copy link

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

@Hiviexd Hiviexd added the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Feb 26, 2024
Copy link
Contributor

@TicClick TicClick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good enough since you didn't aim for cleaning up the whole article -- please address my comments, fix CI errors, and we can get this merged

wiki/Game_mode/osu!taiko/en.md Outdated Show resolved Hide resolved
wiki/Game_mode/osu!taiko/en.md Outdated Show resolved Hide resolved
peppy
peppy previously approved these changes Feb 29, 2024
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an overall improvement 👍

Copy link
Contributor Author

@SherlockWh0 SherlockWh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added changes

Copy link
Member

@Walavouchey Walavouchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force-pushed to squash commits

@Walavouchey Walavouchey removed the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Feb 29, 2024
@Walavouchey Walavouchey changed the title Update Taiko wiki page Update Game mode/osu!taiko Feb 29, 2024
@Walavouchey Walavouchey merged commit f50dfef into ppy:master Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants