Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lazer logo in Release stream/Lazer #11004

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Replace lazer logo in Release stream/Lazer #11004

merged 5 commits into from
Feb 21, 2024

Conversation

noigamegun
Copy link
Contributor

Self-check

@Walavouchey Walavouchey changed the title Replace Lazer Logo In Lazer Wiki Page Replace lazer logo in Release stream/Lazer Feb 21, 2024
Copy link

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

Walavouchey
Walavouchey previously approved these changes Feb 21, 2024
@noigamegun
Copy link
Contributor Author

noigamegun commented Feb 21, 2024

Do i need to edit it?

Error: You have edited some original articles (en.md), but did not outdate their translations:
* wiki/Client/Release_stream/Lazer/de.md
* wiki/Client/Release_stream/Lazer/es.md
* wiki/Client/Release_stream/Lazer/fr.md
* wiki/Client/Release_stream/Lazer/zh.md

If your changes DON'T NEED to be added to the translations, add SKIP_OUTDATED_CHECK anywhere in the description of your pull request.
Otherwise, add the following to each article's front matter (https://osu.ppy.sh/wiki/en/Article_styling_criteria/Formatting#front-matter):

---
outdated_since: e6f41456650d8e739[23](https://github.com/ppy/osu-wiki/actions/runs/7988466282/job/21813096661?pr=11004#step:14:24)051075c6b8df3574bb88c
outdated_translation: true
---
Error: Process completed with exit code 1.

if not then i can just add the outdated transalation

@Walavouchey
Copy link
Member

Walavouchey commented Feb 21, 2024

i've fixed it for you, see the above commit

in the future, make a new branch before making changes (don't pr from master). more info here

@Walavouchey Walavouchey merged commit c52b109 into ppy:master Feb 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants