Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GB Cup 2024 Spring tournament article #11044

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add GB Cup 2024 Spring tournament article #11044

merged 3 commits into from
Feb 29, 2024

Conversation

yobrevelc
Copy link
Contributor

@yobrevelc yobrevelc commented Feb 29, 2024 •
edited
Loading

Self-check

Walavouchey
Walavouchey requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@Walavouchey Walavouchey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please apply any applicable changes to the chinese version as well

wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
wiki/Tournaments/GBC/GBC_2024_Spring/en.md Outdated Show resolved Hide resolved
@Walavouchey
Copy link
Member

Walavouchey commented Feb 29, 2024 •
edited
Loading

@yobrevelc please apply reviews in batches as detailed in https://osu.ppy.sh/wiki/en/osu%21_wiki/Contribution_guide/Best_practices#applying-reviews

(i'll fix the commit spam before merging)

@Walavouchey Walavouchey added the state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc. label Feb 29, 2024
@Walavouchey Walavouchey changed the title Add Tournament Wiki GBC 2024 Spring Add GB Cup 2024 Spring tournament article Feb 29, 2024
Walavouchey
Walavouchey approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@Walavouchey Walavouchey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force-pushed to squash 20+ commits

@Walavouchey Walavouchey merged commit 42f04cf into ppy:master Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iSlodinxOsu iSlodinxOsu iSlodinxOsu requested changes

@Walavouchey Walavouchey Walavouchey approved these changes

Assignees
No one assigned
Labels
area:tournaments size/L state/needs rebase before merging, a maintainer will rebase to fix commit messages, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yobrevelc @Walavouchey @iSlodinxOsu