Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matplotlib theme for creating graphs for newsposts and wiki articles #7911

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

bdach
Copy link
Contributor

@bdach bdach commented Aug 28, 2022

In the past, I have been responsible for creating graph illustrations for multiple performance points newsposts. I've had the styling code lying around on my machine, and people have been asking for it now and again - I've used gists in the past to spread this around, but that doesn't seem sustainable anymore what with multiple pp committees and multiple contributors.

I wanted to clean this stuff up and put it in a git repo, but I wasn't sure what was the best place for it - @Walavouchey suggested that the osu! wiki may be able to take them in under the meta/ directory. So, here they are, PR'd.

If you think there's a better place to put this than the wiki then I'm all ears. Originally I was thinking maybe a separate repo under the ppy org, but I'm not sure about visibility in that case.

README.md contains an explanation how to use these. It's autogenerated from the README.ipynb jupyter notebook. Ideally I would commit just the notebook and not have to bother with the generation, but github doesn't like it - the notebook will render just fine if you open the particular file, but won't render if you open the containing directory itself. Therefore the extra steps with the generate_readme.sh script.

@Walavouchey Walavouchey added the area:meta non-article files label Aug 28, 2022
@peppy peppy merged commit b4a00b7 into ppy:master Aug 29, 2022
@bdach bdach deleted the osu-matplotlib-theme branch August 29, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:meta non-article files size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants