Add configuration option to disable Taiko notes flying after hit #31665
Conversation
|
Short demo: taiko_demo.mp4 |
|
Just a personal opinion as a taiko player, I like this but it feels like the fade effect takes too long, I feel like I'm hitting late because the note disappears late. For comparison, stable faded the notes instantly. |
aedoq
force-pushed
the
hit-flying-config
branch
from
ae0515c to
ef45c1d
Compare
|
@LittleLilyBun You're right, I changed this to be the same as in stable, should be less jarring: 2025-01-24.23-07-48.mp4 |
|
As an aside, I made a somewhat related pull request about a year ago addressing the animation of the flying notes not snapping to the center of the judgement area like they do in stable: #26926 Perhaps these two features could be combined together into a single setting as they both relate to the appearance of the flying notes? Would wait on the thoughts of a maintainer before making any changes. |
|
I'm not going to make a call on this one because this is something that would've been addressed by ruleset skinning. Will defer to @peppy. |
Skimming through that PR, it seems that these are completely separate issues? The "flying away" animation is not an object subject to skinning in any case, it is simply the animation path of Taiko hit objects. It is more in line with configurable circle snapping, which is currently locked behind the classic mod. Also, I might add that if I understood the code correctly, the animation anyway has a discontinuous second derivative which would need fixing. (If an object moves |
| @@ -18,11 +18,13 @@ protected override void InitialiseDefaults() | |||
| base.InitialiseDefaults(); | |||
|
|
|||
| SetDefault(TaikoRulesetSetting.TouchControlScheme, TaikoTouchControlScheme.KDDK); | |||
| SetDefault(TaikoRulesetSetting.HitFlyingEnable, TaikoHitFlyingEnable.Always); | |||
There was a problem hiding this comment.
Shouldn't this be sometimes to match stable?
There was a problem hiding this comment.
I had assumed the behaviour in lazer is intentional, since the animation is also no longer related to the health bar. So I just added a ClassicDefault that matches stable. Should the lazer default be sometimes as well?
| { | ||
| rulesetConfig.BindWith(TaikoRulesetSetting.HitFlyingEnable, hitFlyingEnableSetting); | ||
| hitFlyingEnableSetting.BindValueChanged(_ => updateHitFlying()); | ||
| osuConfig.BindWith(OsuSetting.HUDVisibilityMode, hudVisible); |
There was a problem hiding this comment.
This will look wrong during replays and when the hold-for-hud key is held.
There was a problem hiding this comment.
Hmm you're right. Ideally we could bind to HUDOverlay.ShowHud here, but I'm not familiar enough with the framework to get the DI right. It gives me a DependencyNotRegisteredException if I try to [Resolved] it.
On a related note: Is it fine if, like now, the decision to show a flying note is only taken once, such that enabling the HUD will not show the animation for notes that have already passed?
| @@ -39,6 +42,9 @@ public TaikoAction? HitAction | |||
| private double? lastPressHandleTime; | |||
|
|
|||
| private readonly Bindable<HitType> type = new Bindable<HitType>(); | |||
| private readonly Bindable<TaikoHitFlyingEnable> hitFlyingEnableSetting = new Bindable<TaikoHitFlyingEnable>(); | |||
| private readonly Bindable<HUDVisibilityMode> hudVisible = new Bindable<HUDVisibilityMode>(); | |||
| protected bool ShowFlyingHits; | |||
There was a problem hiding this comment.
This is flimsy. If this isn't in the right value before LoadComplete, it won't be handled correctly in DrawableFlyingHit.
There was a problem hiding this comment.
This should be fine now, since DrawableFlyingHit has no logic on this anymore?
| @@ -26,6 +26,11 @@ protected override void LoadComplete() | |||
| { | |||
| base.LoadComplete(); | |||
| ApplyMaxResult(); | |||
|
|
|||
| if (!ShowFlyingHits) | |||
There was a problem hiding this comment.
This wasn't necessary it turns out. I removed this.
In osu!stable, the "flying away" animation is shown only when the HUD is active. This adds a configuration option to restore this behaviour or to disable the animation altogether.
aedoq
force-pushed
the
hit-flying-config
branch
from
ef45c1d to
9431df3
Compare
In osu!stable, the "flying away" animation is shown only when the HUD is active. This adds a configuration option to restore this behaviour or to disable the animation altogether.
Discussed previously: #23656