Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Skill Attributes to display contribution to StarRating #32426

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

Lawtrohux
Copy link
Member

Very small change but this enables osu!taiko to

  • Commence Performance Points refactor, with per skill performance point calculation and weighting
  • Accurately display each skill's contribution to SR.

There is absolutely 0 value change, as its purely attribute based.

This will be the beginning of some small refactors to improve our access and readability.

Copy link
Contributor

@YaniFR YaniFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good to go

@tsunyoku tsunyoku enabled auto-merge (squash) March 24, 2025 10:03
@tsunyoku tsunyoku merged commit 8b11be5 into ppy:pp-dev Mar 24, 2025
7 of 8 checks passed
@Lawtrohux Lawtrohux deleted the skills-refactor branch March 24, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

3 participants