Show full rank in extended results screen #32428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dunno if it's simple? if we're changing this it should be changed in all usages of cc @peppy @frenzibyte for song select considerations |
|
Probably showing full number in all locations (where possible) is best, since that's what we do on stable, web. |
bdach
previously approved these changes
Mar 24, 2025
bdach
approved these changes
Mar 24, 2025
peppy
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find an issue for this, but I believe I've seen it be discussed before. There is more than enough space to show the full rank on the results screen and none of the other stats are shortened. I figured I could PR it straight up since it's so simple.
Before:
After: