Build iOS tests project #32437
Merged
Build iOS tests project #32437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
added
area:test coverage
frenzibyte
previously approved these changes
Mar 19, 2025
Member
frenzibyte
left a comment
frenzibyte
left a comment
There was a problem hiding this comment.
Seems harmless, I'm surprised we weren't building those before.
Collaborator
|
There's a bunch of build warnings from the test project build (https://github.com/ppy/osu/actions/runs/13917562250/job/38943300105#step:5:204), I'd rather they weren't there. Even if by a warning suppression in the csproj or something. |
Pulls in `<NoWarn>` and inclusion of test resources.
peppy
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may fail a CI run or two...