Fade out pause loop sound when the game window is inactive #32450
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
reviewed
Mar 19, 2025
| if (host != null) | ||
| { | ||
| windowActive = host.IsActive.GetBoundCopy(); | ||
| windowActive.BindValueChanged(_ => Schedule(() => pauseLoop.VolumeTo(targetVolume, 1000, Easing.Out))); |
There was a problem hiding this comment.
BindValueChanged() callback in BDL rather than in LoadComplete()? Also what's with the schedule, is it a workaround for this being in BDL?
There was a problem hiding this comment.
The schedule is very unfortunate. It seems the window active flag is not always on the update thread...
There was a problem hiding this comment.
I figured that might have been the case as well, sure.
peppy
force-pushed
the
no-pause-loop-when-inactive-window
branch
from
d949f8b to
c1604a7
Compare
bdach
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32432.