-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few fixes #137
base: master
Are you sure you want to change the base?
Few fixes #137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
<div style={{width: "250px", height: "250px"}}> | ||
<img style={{maxWidth: "100%", maxHeight: "100%"}} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif"/> | ||
<div style={{ width: "250px", height: "250px" }}> | ||
<img style={{ maxWidth: "100%", maxHeight: "100%" }} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
<div style={{width: "250px", height: "250px"}}> | ||
<img style={{maxWidth: "100%", maxHeight: "100%"}} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif"/> | ||
<div style={{ width: "250px", height: "250px" }}> | ||
<img style={{ maxWidth: "100%", maxHeight: "100%" }} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
Hello guys, any news with this one ? I have same issue with dynamic update of the item. Thanks for your time, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
<div style={{width: "250px", height: "250px"}}> | ||
<img style={{maxWidth: "100%", maxHeight: "100%"}} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif"/> | ||
<div style={{ width: "250px", height: "250px" }}> | ||
<img style={{ maxWidth: "100%", maxHeight: "100%" }} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
<div style={{width: "250px", height: "250px"}}> | ||
<img style={{maxWidth: "100%", maxHeight: "100%"}} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif"/> | ||
<div style={{ width: "250px", height: "250px" }}> | ||
<img style={{ maxWidth: "100%", maxHeight: "100%" }} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
<div style={{width: "250px", height: "250px"}}> | ||
<img style={{maxWidth: "100%", maxHeight: "100%"}} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif"/> | ||
<div style={{ width: "250px", height: "250px" }}> | ||
<img style={{ maxWidth: "100%", maxHeight: "100%" }} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
<div style={{width: "250px", height: "250px"}}> | ||
<img style={{maxWidth: "100%", maxHeight: "100%"}} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif"/> | ||
<div style={{ width: "250px", height: "250px" }}> | ||
<img style={{ maxWidth: "100%", maxHeight: "100%" }} src="https://cdn.tutsplus.com/net/uploads/2013/08/github-collab-retina-preview.gif" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
Kudos, SonarCloud Quality Gate passed! |
No description provided.