add click event handler for title; add read full button in the footer…#420
add click event handler for title; add read full button in the footer…#420AlSharp wants to merge 1 commit intoprabhuignoto:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AlSharp thanks for opening the PR. can you describe what is the change actually. i see a read full button next to read more. why do we need a click handler for the title? Always please add a detailed description when opening a PR so its clear what we are trying to achieve. |
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "react-chrono", | |||
| "name": "react-chrono-extra", | |||
There was a problem hiding this comment.
why the package name is being changed
my guess would be that the title in of itself can be clickable, which would be a nice touch to have when a timeline item has a url, As for the button i guess its just to show the difference (or a option to have to user either or) In regards to the title being a link, I support the adding(and would like to see) instead of having to create a button for the url to be clickable as the title can serve both functions. My use case of it would to be having it be able to open a local file path (obsidian file.path to .md file) while still keeping the timeline a clean look to it. |
No description provided.