-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create event for art market #53
Conversation
|
@hamoid yeah, the pr preview doesn't work fully, because the jekyll compiles it relative to the url in the config. |
I think there's a html tag that could help... something like "base". Not sure if it can be useful... |
The idea would be to add https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base on that preview, but can one add such tag conditionally? |
(from the preview action docs) |
I'm working on it. I think the solution is to set the baseurl in the jekyll build to the right route, which is pr-preview/pr-. I just need to figure out how to get the pr number |
Hmm, still not working. @hamoid any other ideas? |
assets/img/events/2024-art-market/The-Art-Market-3-posters-04-crop.jpg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :)
Created as an event, but not a news item. Website still needs work in order to add news items to front page.