Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create event for art market #53

Merged
merged 7 commits into from
Sep 16, 2024
Merged

create event for art market #53

merged 7 commits into from
Sep 16, 2024

Conversation

mingness
Copy link
Member

Created as an event, but not a news item. Website still needs work in order to add news items to front page.

@mingness mingness changed the title create event for art market create event for art market [WIP] Sep 16, 2024
@mingness mingness changed the title create event for art market [WIP] create event for art market Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-16 10:30 UTC

@mingness
Copy link
Member Author

@hamoid yeah, the pr preview doesn't work fully, because the jekyll compiles it relative to the url in the config.

@hamoid
Copy link
Member

hamoid commented Sep 16, 2024

I think there's a html tag that could help... something like "base". Not sure if it can be useful...

@hamoid
Copy link
Member

hamoid commented Sep 16, 2024

The idea would be to add https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base on that preview, but can one add such tag conditionally?

@hamoid
Copy link
Member

hamoid commented Sep 16, 2024

custom-url: Base URL to use when providing a link to the preview site.

Default: Will attempt to calculate the repository's GitHub Pages URL (e.g. "rossjrw.github.io").

(from the preview action docs)

@hamoid
Copy link
Member

hamoid commented Sep 16, 2024

@mingness
Copy link
Member Author

I'm working on it. I think the solution is to set the baseurl in the jekyll build to the right route, which is pr-preview/pr-. I just need to figure out how to get the pr number

@mingness
Copy link
Member Author

Hmm, still not working. @hamoid any other ideas?

Copy link
Member

@hamoid hamoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :)

@mingness mingness merged commit f39d947 into main Sep 16, 2024
1 check passed
@mingness mingness deleted the art-market branch September 16, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants