add relative url to all resource urls #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingness
force-pushed
the
56-fix-pr-preview-to-work-with-jekyll
branch
from
d6b666b
to
b0b96c7
Compare
|
|
@hamoid I'll need your help to edit url to open call. I don't see how you added the image and link. Current unresolved issues - bg image on homepage not resolving, also video on art market page not playing. |
|
@hamoid could I pass the torch to you? This isn't an urgent issue either. So leave it if you'd like. I'll just need to take a break for a couple weeks to prioritize other work. |
|
Sure. Thanks for doing this already!! I'll take a look. |
hamoid
previously approved these changes
Sep 18, 2024
mingness
changed the title
Martika-lex
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does is change all URLs in the website to relative.
This is needed so the new automatic Pull Request "Previewer" produces a temporary website in which links and media refer to that preview website (instead of to the live website).
Otherwise clicked links take the user to the live website, and new images are not found (because they do not yet exist in the live website).