little refactors #34
Closed
little refactors #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesser context switching this way
| "document": raw_models["documents"][i], | ||
| } | ||
| ) | ||
| model_embeddings = self.__collection.get(ids=model_ids) |
There was a problem hiding this comment.
What does chroma_db.collection.get() return if there are no documents with IDs that match your query?
There was a problem hiding this comment.
i think it returns an empty GetResult object
class GetResult(TypedDict):
ids: List[ID]
embeddings: Optional[List[Embedding]]
documents: Optional[List[Document]]
uris: Optional[URIs]
data: Optional[Loadable]
metadatas: Optional[List[Metadata]]
There was a problem hiding this comment.
How does len(empty GetResult) behave in this instance? Does the function still return an empty array?
There was a problem hiding this comment.
should i test it?
the only call to this function is in /client/pages/vector.py:
with view_tab:
...
stored_models = vector_store.get_models()
...
and here we don't supply the parameter ids, in which case chroma_db.Collection.get() is called with no arguments, and it returns all the models
|
Closing because the code has undergone major changes since this was created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.