Fix flaky test

[prathyushreddylpr]

Description
Fixed the flaky test withTextValuesMap inside the StandardImageMetadataSupportTest class.

TwelveMonkeys/imageio/imageio-core/src/test/java/com/twelvemonkeys/imageio/StandardImageMetadataSupportTest.java

Line 172 in a57a1d3

public void withTextValuesMap() {

Root Cause
The test withTextValuesMap has been reported as flaky when run with the NonDex tool. The test failed because it is trying to compare the keys and values of a Map(entries) with that of the values in a NodeList. The values of the map are hardcoded in the code and compared with those of the values in NodeList. But the Map is initialized to be a HashMap and the HashMap in Java is implemented in such a way that it does not store the order in which the keys and values are inserted.

Fix
This test is fixed by replacing the HashMap with LinkedHashMap. The order in which the elements are entered is preserved inside LinkedHashMap, so when we compare the values with those of in NodeList(textEntries) the test runs as expected.

How this has been tested?

Java: openjdk version "11.0.20.1"
Maven: Apache Maven 3.6.3

1. Module build - Successful
   Command used -

mvn install -pl infra/common -am -DskipTests

2. Regular test - Successful
   Command used -

mvn -pl imageio/imageio-core test -Dtest=com.twelvemonkeys.imageio.StandardImageMetadataSupportTest#withTextValuesMap

3. NonDex test - Failed
   Command used -

mvn -pl imageio/imageio-core edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=com.twelvemonkeys.imageio.StandardImageMetadataSupportTest#withTextValuesMap

NonDex test passed after the fix.

[CaseyPan]

LGTM. One suggestion to consider is either removing the screenshots or providing additional information about the NonDex testing tool for reference.

[zzjas]

Please address the same comment at prathyushreddylpr/druid#1

[prathyushreddylpr]

LGTM. One suggestion to consider is either removing the screenshots or providing additional information about the NonDex testing tool for reference.

Updated

[prathyushreddylpr]

Please address the same comment at prathyushreddylpr/druid#1

Updated

[zzjas]

You can proceed to open a real PR. Once you open a real PR, please mark this tentative PR as Opened in your tentative_pr.csv file and also raise a PR to IDoFT marking this as Opened. Thanks!

[zzjas]

Have you opened a real PR for this? If so, please mark this as "Opened" in your tentative_pr.csv file and also raise a PR to IDoFT marking this as Opened. Thanks!