Update stop_sign_urban_intersection_3c.json #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I run : python baseline_agent.py --config /home/tianyushi/code/macad-gym/src/macad_gym/envs/intersection/stop_sign_urban_intersection_3c.json in the path: /home/tianyushi/code/macad-agents/src/macad_agents I found some configurations are missing in this jason file.
praveen-palanisamy
requested changes
Sep 5, 2020
| "env": { | ||
| "server_map": "/Game/Carla/Maps/Town03", | ||
| "render": true, | ||
| "render_x_res": 800, |
There was a problem hiding this comment.
Can you please remove the extra space in the beginning of this line (Line 6) and the next line (Line 7) so that it aligns with the previous line (Line 5)?
This will maintain readability with uniform visual indent.
| "spectator_loc": [140, 68, 9], | ||
| "synch_server": true | ||
| "sync_server": true, | ||
| "fixed_delta_seconds": 0.05 |
There was a problem hiding this comment.
Same. Needs a visual indent fix. Please remove the extra space in the beginning.
praveen-palanisamy
requested changes
Sep 6, 2020
| "squash_action_logits": false, | ||
| "verbose": false, | ||
| "use_depth_camera": false, | ||
| "use_depth_camera": false, |
There was a problem hiding this comment.
Please undo this change to remove the extra space in the beginning.
| "use_depth_camera": false, | ||
| "send_measurements": false, | ||
| "enable_planner": true, | ||
| "enable_planner": true, |
There was a problem hiding this comment.
Please undo this change to keep the visual indent aligned.
|
@SHITIANYU-hue , you can make the changes and update this PR by pushing to the same branch ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run :
python baseline_agent.py --config /home/tianyushi/code/macadgym/src/macad_gym/envs/intersection/stop_sign_urban_intersection_3c.json
in the path: /home/tianyushi/code/macad-agents/src/macad_agents
I found some configurations are missing in this jason file.