-
-
Notifications
You must be signed in to change notification settings - Fork 137
fix: Fixes typing in Store when connecting #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@prazdevs Hi. Do you have the ability to accept the PR? |
@prazdevs Please have a look, this is affecting our project as well. |
That's rather odd because the type doesn't need to be imported as its used inside |
This error is reproduced on large projects, it looks like TS is failing. Is there any reason why the |
It has never been added to my knowledge. We're redeclaring the module ( |
Closing this without a proper issue / reproduction repo where the error occurs 😥 |
I only got around to trying to create a repro today. I started with our project's source code and removed code until there was no error running This is the repro: https://github.com/agross/pinia-repro Please reopen here accordingly. To "fix" the error, run |
@agross Thanks for the tip on how to look for the problem. I have found what the cause is. TS is trying to optimize AST. So it is not loading data that is not being used right now. To load the extension type, you can do an import from a package that extends pinia. @prazdevs reopen the current PR and I will add a fix. |
- added PersistType for import
37a6f0d
to
d170382
Compare
Description
When pinia-plugin-persistedstate is connected - stor types are broken.
The problem is that the type used is not imported.
This PR fixes this error.