Skip to content

Add a test to cover components using Array.map in the react transform #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

alxclark
Copy link
Contributor

@alxclark alxclark commented Apr 4, 2024

No description provided.

Copy link

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: 4c7984e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 4c7984e
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/66937a3c0a34f00008c307f5
😎 Deploy Preview https://deploy-preview-551--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alxclark alxclark force-pushed the alx/transform-children-map branch from 2f3bf17 to ad82ade Compare April 4, 2024 22:19
Comment on lines +495 to +497
expect(scratch.innerHTML).to.equal(
"<div><div>Hello Jane</div><div>Goodbye Jane</div></div>"
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@JoviDeCroock JoviDeCroock marked this pull request as ready for review July 14, 2024 10:11
@JoviDeCroock JoviDeCroock merged commit 10e13d3 into preactjs:main Jul 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants