-
-
Notifications
You must be signed in to change notification settings - Fork 113
feat(react-transform): Suppport require syntax in our babel transform #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a28dc05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: +348 B (+0.43%) Total Size: 81.4 kB
ℹ️ View Unchanged
|
LGTM, but a test case would be nice |
@marvinhagemeister good shout, was still figuring out how to trick the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than the thing I mentioned in Slack.
I imagine this doesn't need any altered instructions for the end user then? They can add the Babel plugin in the same way and all will work?
Any progress with this PR? I started a new React Native App, and would love to give it a try to signals |
Noticed we threw an error for non-ESM modules, so added support for that as we are exporting a CJS build of our react-bindings either way.
CC @andrewiggins not sure if you opted out here for a reason
Fixes #575