Add type as Node | undefined to head

[nishan-singh]

I removed duplicated node source version check in needToRecompute func and make the head's type Node | undefined in cleanUpSources func.

[changeset-bot]

⚠️ No Changeset found

Latest commit: d5a6f59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for preact-signals-demo ready!

Name	Link
🔨 Latest commit	d5a6f59
🔍 Latest deploy log	https://app.netlify.com/projects/preact-signals-demo/deploys/6840a08c1817260008bcaa6d
😎 Deploy Preview	https://deploy-preview-674--preact-signals-demo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[JoviDeCroock]

Your PR needs a changeset

[nishan-singh]

I added a changeset. I hope I did it right. I'm really sorry if I messed it up. I have never contributed to open source before.

[rschristian]

Sorry for the delay here, been quite busy.

It looks like this change isn't quite as innocent as it appears, judging by the state of the CI. ._refresh() will need to be called prior to the check of ._version if the version matches, which this PR breaks.

We might be able to get away with removing the first check instead, though that might hurt benchmarks a bit. Would need to take a deeper look into that.

PR breaks multiple test cases

[nishan-singh]

Now it calls _refesh() before checking the _version. I ran the tests locally and they seem to pass.

Here is a screenshot:

[jviide]

The check is not redundant. The first node._source._version !== node._version checks whether the node._source's value has definitely changed since the node._version was last set. If so, we can skip the node._refresh() check. The second node._source._version !== node._version checks whether node._source's version has changed after the refresh.

This is what the comment "If there's a new version of the dependency before or after refreshing" above the code alludes to.

[marvinhagemeister]

^What @jviide said. It's a performance optimization.

[jviide]

Tried to address the ambiguousness of the code in #690. Thank you @nishan-singh for pointing this out 👍

Stale