Skip to content

test: migrate core tests to vitest #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2025

Conversation

43081j
Copy link

@43081j 43081j commented Jun 28, 2025

Migrates the core package to use vitest.

just noticed we won't get CI for these branches 😬 not sure i want to have to change the workflow triggers though 🤔

depends on #713

Copy link

changeset-bot bot commented Jun 29, 2025

⚠️ No Changeset found

Latest commit: 91e5b60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@43081j 43081j force-pushed the vitest-core branch 2 times, most recently from 5c7520e to 039b755 Compare June 29, 2025 21:37
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just add it temp if you like

@43081j
Copy link
Author

43081j commented Jun 30, 2025

that'd be helpful i think, and can drop it in the overall merge

@JoviDeCroock
Copy link
Member

CI should run after rebasing

Migrates the core package to use vitest.
@JoviDeCroock JoviDeCroock merged commit 2830b0e into preactjs:vitest-migration Jul 5, 2025
1 check passed
@43081j 43081j deleted the vitest-core branch July 5, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants