Skip to content

Vitest migration #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Vitest migration #709

wants to merge 5 commits into from

Conversation

JoviDeCroock
Copy link
Member

Adds vitest and associated scripts which will not succeed yet, as we have no projects.

Copy link

changeset-bot bot commented Jun 28, 2025

⚠️ No Changeset found

Latest commit: 2830b0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoviDeCroock JoviDeCroock changed the title test: add vitest prep (#707) Vitest migration Jun 28, 2025
Copy link

netlify bot commented Jun 28, 2025

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 2830b0e
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/6868e5a869056a0008c71e94
😎 Deploy Preview https://deploy-preview-709--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

github-actions bot commented Jun 28, 2025

Size Change: 0 B

Total Size: 87.6 kB

ℹ️ View Unchanged
Filename Size
docs/dist/assets/bench.********.js 1.59 kB
docs/dist/assets/client.********.js 46.2 kB
docs/dist/assets/index.********.js 1.09 kB
docs/dist/assets/jsxRuntime.module.********.js 283 B
docs/dist/assets/preact.module.********.js 4.01 kB
docs/dist/assets/signals-core.module.********.js 1.53 kB
docs/dist/assets/signals.module.********.js 2.04 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.24 kB
docs/dist/basic-********.js 243 B
docs/dist/demos-********.js 4.32 kB
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 239 B
packages/core/dist/signals-core.js 1.56 kB
packages/core/dist/signals-core.mjs 1.57 kB
packages/preact/dist/signals.js 1.57 kB
packages/preact/dist/signals.mjs 1.53 kB
packages/react-transform/dist/signals-*********.js 5.93 kB
packages/react-transform/dist/signals-transform.mjs 5.12 kB
packages/react-transform/dist/signals-transform.umd.js 6.04 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

43081j added 2 commits June 30, 2025 10:51
Adds vitest and associated scripts which will not succeed yet, as we
have no projects.
We were quickly going to end up with too many sub-configs, and all sorts
of problems with extending the various configs.

This switches to a single root config which globs each of the monorepo
packages instead.
@43081j
Copy link

43081j commented Jul 1, 2025

CI of these will fail right now because it seems vite requires node 20+

we might have to downgrade vite for now, presumably the previous major worked on 18.x

43081j added 3 commits July 2, 2025 19:12
* test: migrate preact/utils to vitest

This also adds `preact/utils` to the pnpm workspace so it can be
resolved properly via `@preact/signals-utils`.

* chore: revert workspace change

* fix: downgrade to vite 6 and revert the revert
Migrates the signals package to use vitest browser tests.
Migrates the core package to use vitest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants