Skip to content

test: migrate signals package to vitest #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025

Conversation

43081j
Copy link

@43081j 43081j commented Jun 28, 2025

Migrates the signals package to use vitest browser tests.

Copy link

changeset-bot bot commented Jun 29, 2025

⚠️ No Changeset found

Latest commit: 2930619

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Migrates the signals package to use vitest browser tests.
@43081j
Copy link
Author

43081j commented Jul 3, 2025

we should be able to merge this one now 👍

@JoviDeCroock
Copy link
Member

The coverage result does look wrong as it reports 0% lines covered for example

@43081j
Copy link
Author

43081j commented Jul 3, 2025

i think its broken on the vitest-migration branch in general, so i was planning on fixing it in one go once we have all the tests running

@JoviDeCroock JoviDeCroock merged commit f79820a into preactjs:vitest-migration Jul 3, 2025
1 check passed
@43081j 43081j deleted the vitest-signals branch July 3, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants