Rewrite node module handling (npm plugin) #874
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3043967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marvinhagemeister
force-pushed
the
npm-refactor2
branch
2 times, most recently
from
87b2ca9 to
3a5a48c
Compare
marvinhagemeister
force-pushed
the
npm-refactor2
branch
from
3a5a48c to
a9e22b7
Compare
marvinhagemeister
force-pushed
the
npm-refactor2
branch
from
5b1edcd to
3043967
Compare
developit
reviewed
Oct 22, 2021
| log(kl.dim(`downloading... `) + kl.cyan(id)); | ||
| // Download tarball to disk | ||
| const tarPath = path.join(downloadDir, `${safeName}-${version}.tgz`); | ||
| await streamToDisk(tarball, tarPath); |
There was a problem hiding this comment.
seems like this could instead stream directly into parseTarball, to skip the disk write+read and cut memory usage in half.
|
Hey! Nice PR, I need this change in order to work with wmr... maybe I can help somehow to make this PR go through? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rewrite of the way we handle node modules and fetch them from the npm registry.
browserfield inpackage.jsondevelopmentandproductionhandling into a single plugin. Previously, we used a middleware duringdevelopmentand a rollup plugin forproduction--autoInstalland is disabled by default. The auto install feature is contained in a separate plugin.node_modulesfolder with the package we're looking for.--registry.setCwdhack 🎉Todos:
etagcachingBring back brotli compression background upgrades- already presentFixes #299, fixes #784, fixes #285, fixes #135, fixes #109, fixes #151, fixes #167