NextMillennium: Adapter and server version #3814

przemkaczmarek · 2025-03-06T14:00:08Z

🔧 Type of changes

bid adapter update

✨ What's the context?

AntoxaAntoxic · 2025-03-07T12:12:49Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

+        final ExtRequestPrebid updatedExt = extRequestPrebid.toBuilder()
+                .nextMillennium(ExtRequestNextMillennium.of(
+                        nmmFlags,
+                        NM_ADAPTER_VERSION,
+                        versionProvider.getNameVersionRecord()))
                .build();


In Go they don't update ext or ext.prebid, they create new objects

AntoxaAntoxic · 2025-03-07T12:14:23Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

+        return bidRequest.toBuilder()
+                .imp(bidRequest.getImp())
+                .ext(ExtRequest.of(updatedExt))
+                .build();


imp[0].ext update is missing

AntoxaAntoxic · 2025-03-07T12:19:46Z

src/main/java/org/prebid/server/proto/openrtb/ext/request/ExtRequestPrebid.java

+    /**
+     * Defines the contract for bidrequest.ext.prebid.nextMillennium
+     */
+    ExtRequestNextMillennium nextMillennium;


deserialization is incorrect here

...ava/org/prebid/server/proto/openrtb/ext/request/nextmillennium/ExtRequestNextMillennium.java

AntoxaAntoxic · 2025-03-10T15:01:53Z

...ava/org/prebid/server/proto/openrtb/ext/request/nextmillennium/ExtRequestNextMillennium.java

    List<String> nmmFlags;

+    @JsonProperty("nm_version")


I think its not redutat because i got from server:

and how about "still incorrect, it should be nmmFlags" i have got n m m F l a g s . where is a problem?

the annotation is redundant

i have got n m m F l a g s . where is a problem? Sorry, I didn't get. According to the Go the field should be serialized into the nnmFlags instead of nnm_flags

nnm or nmm ? I have got nmm in Go and Java

the point was about the case, it should be nmmFlags instead of the nmm_flags in the bidder request

AntoxaAntoxic · 2025-03-10T15:02:00Z

...ava/org/prebid/server/proto/openrtb/ext/request/nextmillennium/ExtRequestNextMillennium.java

    String nmVersion;

+    @JsonProperty("server_version")


AntoxaAntoxic · 2025-03-10T15:05:19Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

+        final ObjectNode nextMillenniumNode = mapper.mapper().valueToTree(
+                ExtRequestNextMillennium.of(nmmFlags, NM_ADAPTER_VERSION, versionProvider.getNameVersionRecord()));
+
+        extRequest.addProperty("next_millennium", nextMillenniumNode);


incorrect property name, should be nextMillennium

AntoxaAntoxic · 2025-03-10T15:07:32Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

+        final ObjectNode updatedImpExt = mapper.mapper().createObjectNode();
+        updatedImpExt.set("bidder", mapper.mapper().valueToTree(ext));


what is this? I don't see any bidder field in the bidder request

in L11-15 there is bidder field:

"ext": { "bidder": { "placement_id": "placement_id" } }

the Go doesn't have it

AntoxaAntoxic · 2025-03-10T15:11:50Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

                .build();

        return bidRequest.toBuilder()
-                .imp(bidRequest.getImp())
-                .ext(ExtRequest.of(updatedExt))
+                .imp(List.of(updatedImp))


it should update only a first imp, but not replace the whole list of imps with a single one

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

AntoxaAntoxic · 2025-03-11T12:47:45Z

...ava/org/prebid/server/proto/openrtb/ext/request/nextmillennium/ExtRequestNextMillennium.java

+    @JsonProperty("nmmFlags")
+    List<String> nmmFlags;
+
+    @JsonProperty("nmVersion")


remove annotation

I think we should keep it because when i remove it test failed.

from server i recived fields with _
fe. i recived "nmm_flags"

it means the test is incorrect

this is the mapping the Go uses

type nmExtNMM struct { NmmFlags []string `json:"nmmFlags,omitempty"` ServerVersion string `json:"server_version,omitempty"` AdapterVersion string `json:"nm_version,omitempty"` }

AntoxaAntoxic · 2025-03-11T12:47:52Z

...ava/org/prebid/server/proto/openrtb/ext/request/nextmillennium/ExtRequestNextMillennium.java

+    @JsonProperty("nmVersion")
+    String nmVersion;
+
+    @JsonProperty("serverVersion")


remove annotation

AntoxaAntoxic · 2025-03-12T14:49:37Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

@@ -112,7 +112,11 @@ private BidRequest updateBidRequest(BidRequest bidRequest, ExtImpNextMillennium

        final Imp firstImp = bidRequest.getImp().getFirst();
        final ObjectNode updatedImpExt = mapper.mapper().createObjectNode();
-        updatedImpExt.set("bidder", mapper.mapper().valueToTree(ext));
+        updatedImpExt.set("nextMillennium", nextMillenniumNode);


the nextMillenniumNode should have only nmmFlags if it's an imp.ext

AntoxaAntoxic · 2025-03-14T14:52:29Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

@@ -112,7 +112,7 @@ private BidRequest updateBidRequest(BidRequest bidRequest, ExtImpNextMillennium

        final Imp firstImp = bidRequest.getImp().getFirst();
        final ObjectNode updatedImpExt = mapper.mapper().createObjectNode();
-        updatedImpExt.set("nextMillennium", nextMillenniumNode);
+        updatedImpExt.set("nextMillennium", nextMillenniumNode.get("nmmFlags"));


this is incorrect, please observe the Go code one more time

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

...ava/org/prebid/server/proto/openrtb/ext/request/nextmillennium/ExtRequestNextMillennium.java

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

src/test/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidderTest.java

AntoxaAntoxic · 2025-03-19T11:50:35Z

src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

@@ -92,7 +100,7 @@ private ExtImpNextMillennium convertExt(ObjectNode impExt) {
        }
    }

-    private BidRequest updateBidRequest(BidRequest bidRequest, ExtImpNextMillennium ext) {
+    private BidRequest updateBidRequest1(BidRequest bidRequest, ExtImpNextMillennium ext) {


src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

src/test/java/org/prebid/server/it/NextMillenniumTest.java

src/main/java/org/prebid/server/spring/config/bidder/NextMillenniumConfiguration.java

src/test/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidderTest.java

…3744 # Conflicts: # src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

przemkaczmarek added 2 commits March 6, 2025 14:58

NextMillennium: Adapter and server version

333befd

fix server_version

99a129e

przemkaczmarek added the do not port label Mar 6, 2025

przemkaczmarek requested a review from AntoxaAntoxic March 6, 2025 15:06

osulzhenko assigned przemkaczmarek Mar 7, 2025

AntoxaAntoxic requested changes Mar 7, 2025

View reviewed changes

fix comments

34fad7e

przemkaczmarek requested a review from AntoxaAntoxic March 10, 2025 13:09

AntoxaAntoxic requested changes Mar 10, 2025

View reviewed changes

fix comments

961a9c8

AntoxaAntoxic requested changes Mar 11, 2025

View reviewed changes

fix comments

40fdf2f

osulzhenko requested a review from AntoxaAntoxic March 12, 2025 10:49

AntoxaAntoxic requested changes Mar 12, 2025

View reviewed changes

fix comments

9b6a05e

AntoxaAntoxic requested changes Mar 14, 2025

View reviewed changes

fix comments

249843e

CTMBNara requested changes Mar 19, 2025

View reviewed changes

fix comments

97ab21e

AntoxaAntoxic requested changes Mar 19, 2025

View reviewed changes

fix comments

8e6da2f

AntoxaAntoxic previously approved these changes Mar 19, 2025

View reviewed changes

osulzhenko requested a review from CTMBNara March 27, 2025 10:44

CTMBNara requested changes Mar 31, 2025

View reviewed changes

fix comments

fa02a9c

przemkaczmarek dismissed AntoxaAntoxic’s stale review via fa02a9c April 1, 2025 12:05

osulzhenko requested a review from CTMBNara April 11, 2025 05:51

CTMBNara requested changes Apr 17, 2025

View reviewed changes

src/test/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidderTest.java Outdated Show resolved Hide resolved

src/test/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidderTest.java Outdated Show resolved Hide resolved

przemkaczmarek added 2 commits April 17, 2025 13:08

fix comments

95c2a5c

fix comments

4ac1dc4

osulzhenko requested review from AntoxaAntoxic and CTMBNara May 2, 2025 08:16

Merge branch 'master' into NextMillennium-Adapter-and-server-version-#…

2225a20

…3744 # Conflicts: # src/main/java/org/prebid/server/bidder/nextmillennium/NextMillenniumBidder.java

AntoxaAntoxic approved these changes May 9, 2025

View reviewed changes

CTMBNara approved these changes May 15, 2025

View reviewed changes

CTMBNara merged commit 06893a5 into master May 16, 2025
8 checks passed

CTMBNara deleted the NextMillennium-Adapter-and-server-version-#3744 branch May 16, 2025 15:38

osulzhenko pushed a commit that referenced this pull request May 19, 2025

NextMillennium: Adapter and server version (#3814)

3d55952

AntoxaAntoxic mentioned this pull request May 23, 2025

Port PR from PBS-Go: NextMillennium: Adapter and server version #3744

Closed

		final ObjectNode updatedImpExt = mapper.mapper().createObjectNode();
		updatedImpExt.set("bidder", mapper.mapper().valueToTree(ext));

NextMillennium: Adapter and server version #3814

NextMillennium: Adapter and server version #3814

Uh oh!

Conversation

przemkaczmarek commented Mar 6, 2025

🔧 Type of changes

✨ What's the context?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AntoxaAntoxic Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

przemkaczmarek Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AntoxaAntoxic Mar 11, 2025 •

edited

Loading

przemkaczmarek Mar 10, 2025 •

edited

Loading