NextMillennium: Adapter and server version #3814
Conversation
| final ExtRequestPrebid updatedExt = extRequestPrebid.toBuilder() | ||
| .nextMillennium(ExtRequestNextMillennium.of( | ||
| nmmFlags, | ||
| NM_ADAPTER_VERSION, | ||
| versionProvider.getNameVersionRecord())) | ||
| .build(); |
There was a problem hiding this comment.
In Go they don't update ext or ext.prebid, they create new objects
| return bidRequest.toBuilder() | ||
| .imp(bidRequest.getImp()) | ||
| .ext(ExtRequest.of(updatedExt)) | ||
| .build(); |
There was a problem hiding this comment.
imp[0].ext update is missing
| /** | ||
| * Defines the contract for bidrequest.ext.prebid.nextMillennium | ||
| */ | ||
| ExtRequestNextMillennium nextMillennium; |
There was a problem hiding this comment.
deserialization is incorrect here
| @Value(staticConstructor = "of") | ||
| public class ExtRequestNextMillennium { | ||
|
|
||
| List<String> nmmFlags; |
There was a problem hiding this comment.
deserialization is incorrect here
There was a problem hiding this comment.
still incorrect, it should be nmmFlags
| @Value(staticConstructor = "of") | ||
| public class ExtRequestNextMillennium { | ||
|
|
||
| List<String> nmmFlags; |
There was a problem hiding this comment.
still incorrect, it should be nmmFlags
| List<String> nmmFlags; | ||
|
|
||
| @JsonProperty("nm_version") |
There was a problem hiding this comment.
I think its not redutat because i got from server:
and how about "still incorrect, it should be nmmFlags" i have got n m m F l a g s . where is a problem?
There was a problem hiding this comment.
the annotation is redundant
i have got n m m F l a g s . where is a problem? Sorry, I didn't get. According to the Go the field should be serialized into the nnmFlags instead of nnm_flags
There was a problem hiding this comment.
nnm or nmm ? I have got nmm in Go and Java
There was a problem hiding this comment.
the point was about the case, it should be nmmFlags instead of the nmm_flags in the bidder request
| String nmVersion; | ||
|
|
||
| @JsonProperty("server_version") |
| final ObjectNode nextMillenniumNode = mapper.mapper().valueToTree( | ||
| ExtRequestNextMillennium.of(nmmFlags, NM_ADAPTER_VERSION, versionProvider.getNameVersionRecord())); | ||
|
|
||
| extRequest.addProperty("next_millennium", nextMillenniumNode); |
There was a problem hiding this comment.
incorrect property name, should be nextMillennium
| final ObjectNode updatedImpExt = mapper.mapper().createObjectNode(); | ||
| updatedImpExt.set("bidder", mapper.mapper().valueToTree(ext)); |
There was a problem hiding this comment.
what is this? I don't see any bidder field in the bidder request
There was a problem hiding this comment.
in L11-15 there is bidder field:
"ext": {
"bidder": {
"placement_id": "placement_id"
}
}
There was a problem hiding this comment.
the Go doesn't have it
| .build(); | ||
|
|
||
| return bidRequest.toBuilder() | ||
| .imp(bidRequest.getImp()) | ||
| .ext(ExtRequest.of(updatedExt)) | ||
| .imp(List.of(updatedImp)) |
There was a problem hiding this comment.
it should update only a first imp, but not replace the whole list of imps with a single one
| updatedImpExt.set("bidder", mapper.mapper().valueToTree(ext)); | ||
|
|
||
| final Imp updatedImp = firstImp.toBuilder() | ||
| .ext(updatedImpExt) |
There was a problem hiding this comment.
nmmFlags should be added to the imp.ext as well
| @JsonProperty("nmmFlags") | ||
| List<String> nmmFlags; | ||
|
|
||
| @JsonProperty("nmVersion") |
There was a problem hiding this comment.
I think we should keep it because when i remove it test failed.
from server i recived fields with _
fe. i recived "nmm_flags"
There was a problem hiding this comment.
it means the test is incorrect
this is the mapping the Go uses
type nmExtNMM struct {
NmmFlags []string `json:"nmmFlags,omitempty"`
ServerVersion string `json:"server_version,omitempty"`
AdapterVersion string `json:"nm_version,omitempty"`
}
| @JsonProperty("nmVersion") | ||
| String nmVersion; | ||
|
|
||
| @JsonProperty("serverVersion") |
🔧 Type of changes
✨ What's the context?
#3744