Pubmatic: Set bid.meta.mediaType=video when bid.ext.ibv=true #4189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
adapters/pubmatic/pubmatictest/supplemental/bid_ext_ibv_true.json
Outdated
Show resolved
Hide resolved
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
pm-isha-bharti
approved these changes
Feb 18, 2025
|
@guscarreon / @scr-oath Can someone please review this PR? |
scr-oath
approved these changes
Mar 11, 2025
guscarreon
reviewed
Mar 11, 2025
| @@ -637,24 +649,27 @@ func getStringArray(array []interface{}) []string { | |||
| return aString | |||
| } | |||
|
|
|||
| // getBidType returns the bid type specified in the response bid.ext | |||
There was a problem hiding this comment.
Can we update the comment? getMediaTypeForBid doesn't return the bid type from bid.ext anymore.
| bidType = openrtb_ext.BidTypeNative | ||
| mType := openrtb_ext.BidTypeBanner | ||
| if bid != nil { | ||
| switch bid.MType { |
There was a problem hiding this comment.
Are we sure from now on the media type will always be located in bid.MType and not in bid.Ext? Do you think we should look in bid.MType first and then bid.Ext second for backwards compatibility?
|
|
||
| typedBid.BidMeta = &openrtb_ext.ExtBidPrebidMeta{MediaType: string(mType)} | ||
| if bidExt.InBannerVideo { | ||
| typedBid.BidMeta.MediaType = string(openrtb_ext.BidTypeVideo) |
There was a problem hiding this comment.
Is the scenario where bidExt.InBannerVideo is true, but bidExt.VideoCreativeInfo or bidExt.VideoCreativeInfo.Duration is nil, valid? If not, should we validate and append an error to the errs array in such cases?
| } | ||
| if tt.expectedError != nil && actualError == nil { | ||
| t.Errorf("Expected error: %v, but got nil", tt.expectedError) | ||
| } else if tt.expectedError != nil && actualError != nil && actualError.Error() != tt.expectedError.Error() { |
There was a problem hiding this comment.
The if-else statement seems to not compare an tt.expectedError equal to nil. If tt.expectedError equals nil, shouldn't we assert that actualError is also nil?
| @@ -461,26 +462,37 @@ func (a *PubmaticAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externa | |||
| bid.Cat = bid.Cat[0:1] | |||
| } | |||
|
|
|||
| mType, err := getMediaTypeForBid(&bid) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Can we write a JSON test case to cover the error scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.